Skip to content

fix test-huggingface-transformers-* tests #14752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Oct 4, 2025
Merged

fix test-huggingface-transformers-* tests #14752

merged 39 commits into from
Oct 4, 2025
+22 −31

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Oct 2, 2025 •
edited
Loading

Fix these tests https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=huggingface-transformer

The optimum is installed in a bit weird way, inside executorch folder, it clone optimum inside executorch, and try to install executorch in the nested optimum folder. Install optimum via pip instead in the same commit. The behavior should be the same, tests still run as expected

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14752

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit cd1c768 with merge base 4372a14 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai marked this pull request as draft October 2, 2025 17:21
@cccclai cccclai marked this pull request as ready for review October 3, 2025 22:29
@cccclai cccclai merged commit 3d8b8d1 into main Oct 4, 2025
276 of 281 checks passed
@cccclai cccclai deleted the fix_huggingface_transformers_test branch October 4, 2025 23:33
@cccclai
Copy link
Contributor Author

cccclai commented Oct 6, 2025

@pytorchbot cherry-pick --onto release/1.0 -c regression

pytorchbot pushed a commit that referenced this pull request Oct 6, 2025
@cccclai @pytorchbot
fix test-huggingface-transformers-* tests (#14752)
5cdae24 
Fix these tests
https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=huggingface-transformer

The optimum is installed in a bit weird way, inside executorch folder,
it clone optimum inside executorch, and try to install executorch in the
nested optimum folder. Install optimum via pip instead in the same
commit. The behavior should be the same, tests still run as expected

(cherry picked from commit 3d8b8d1)
@pytorchbot
Copy link
Collaborator

Cherry picking #14752

The cherry pick PR is at #14812 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cccclai @pytorchbot @kimishpatel